Guard RedactUrlQueryParamsFilter against None args - #947
Open
jonathanberthias wants to merge 1 commit into
Open
Conversation
urllib3.connectionpool records can arrive with record.args set to None when another logging filter (e.g. MLflow's SensitiveQueryParamFilter) redacts the message and nulls args before this filter runs. Iterating None raised TypeError. Guard the tuple branch with an explicit None check. Also fix a latent typo in the dict-args branch: record.arg[k] should be record.args[k], which would raise AttributeError whenever a record carried dict args. Fixes databricks#946 Signed-off-by: Jonathan Berthias <jvberthias@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
urllib3.connectionpoolrecords can arrive withrecord.argsset toNonewhen another logging filter (e.g. MLflow'sSensitiveQueryParamFilter) redacts the message and nulls args before this filter runs. IteratingNoneraisedTypeError. Guard the tuple branch with an explicitNonecheck.Also fix a typo in the dict-args branch:
record.arg[k]should berecord.args[k], which would raiseAttributeErrorwhenever a record carried dict args.How is this tested?
Related Tickets & Documents
Fixes #946